Skip to content

Feature/footer collabs #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Feature/footer collabs #101

wants to merge 11 commits into from

Conversation

DavidVargas-Ctrl
Copy link

correciones de @Samu-Kiss

@Samu-Kiss
Copy link
Contributor

Ahora siii :)

@Samu-Kiss
Copy link
Contributor

bro, @DavidVargas-Ctrl, me acabo de dar cuenta que el footer en móvil está rarito, yo creo que lo mejor ahí es dejar centrados los elementos. Y los contribuidores sería bueno ponerle el titulito, ese iría en montserrat,

image

@TalkySafe143
Copy link
Member

Finalmente en que quedo este PR? Estará en Draft mientras

@TalkySafe143 TalkySafe143 marked this pull request as draft September 27, 2025 01:04
@Samu-Kiss
Copy link
Contributor

Finalmente en que quedo este PR? Estará en Draft mientras

Hola bro, ya está casi todo. Falta corregir lo de movil

@adrianrrruiz
Copy link
Contributor

@DavidVargas-Ctrl creo que tienes algo pendiente por acá

@DavidVargas-Ctrl
Copy link
Author

listo, lo corregiré entonces

@adrianrrruiz
Copy link
Contributor

Como vas? @DavidVargas-Ctrl

@DavidVargas-Ctrl
Copy link
Author

Lo trabajo el fin de semana, entre semana he estado un poco lleno de cosas

@DavidVargas-Ctrl
Copy link
Author

Listo, ya quedo corregido

@DavidVargas-Ctrl DavidVargas-Ctrl marked this pull request as ready for review October 5, 2025 13:40
@Samu-Kiss
Copy link
Contributor

Listo, ya quedo corregido

epa ya reviso

@Samu-Kiss Samu-Kiss self-requested a review October 5, 2025 15:53
Samu-Kiss
Samu-Kiss requested changes Oct 5, 2025
View reviewed changes
Copy link
Contributor

@Samu-Kiss Samu-Kiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

bro, yo creo que es mejor quitarle ese mini texto que sale de los nombres, no es legible

@adrianrrruiz
Copy link
Contributor

Image bro, yo creo que es mejor quitarle ese mini texto que sale de los nombres, no es legible

@DavidVargas-Ctrl

@DavidVargas-Ctrl
Copy link
Author

Bueno, yo lo quito ;b

@DavidVargas-Ctrl
Copy link
Author

Ya lo quite
cat-thinking

@Samu-Kiss Samu-Kiss self-requested a review October 6, 2025 16:39
Samu-Kiss
Samu-Kiss approved these changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@Samu-Kiss Samu-Kiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, gracias bro

@Samu-Kiss
Copy link
Contributor

@Achalogy @adrianrrruiz porfa alguno revise porfis :)

@Samu-Kiss
Copy link
Contributor

btw el merge no debería ser a develop?

@TalkySafe143 TalkySafe143 changed the base branch from main to develop October 7, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samu-Kiss Samu-Kiss Samu-Kiss approved these changes

@adrianrrruiz adrianrrruiz Awaiting requested review from adrianrrruiz

@Achalogy Achalogy Awaiting requested review from Achalogy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DavidVargas-Ctrl @Samu-Kiss @TalkySafe143 @adrianrrruiz